Issue 300 #301
Merged
Issue 300 #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test new methods used to return users by role
Method to retrieve just agents or admins, or end users or any combination of the previous 3. Also a method to retrieve users in provided enterprise role.
|
Looks good to me Fixes #300 |
abc516
pushed a commit
to abc516/ZendeskApi_v2
that referenced
this pull request
Oct 30, 2019
* Update UserTests.cs to Test New Methods Test new methods used to return users by role * Ability to Get Users by Roles Method to retrieve just agents or admins, or end users or any combination of the previous 3. Also a method to retrieve users in provided enterprise role.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added methods to retrieve just Agents or Admins or End Users, as well as a method to retrieve any combination of those users and a method to return all users from given enterprise role ID.
I did not create a method for multiple enterprise Role IDs, I figure people can just call the method more than once if they need to.
All of this is based on information acquired here https://developer.zendesk.com/rest_api/docs/core/users#filters and I've tested everything but the enterprise stuff and it works for me. Ran all tests, 250 passed and 2 skipped, so that's good. Created my own as well, all 4 ran fine. Wasn't sure how to create one for enterprise method, so I didn't do one for that.
Anyways, this may not be best way to do it, but at least gets the ball rolling :)